Hi Andy, On Tue, Mar 29, 2022 at 6:47 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > On Tue, Mar 29, 2022 at 06:13:19PM +0200, Neil Armstrong wrote: > > On 29/03/2022 17:29, Andy Shevchenko wrote: > > > Rename REG_* to * as a prerequisite for enabling COMPILE_TEST. > > > > What error do you hit ? > > arch/x86/include/asm/arch_hweight.h:9:17: error: expected identifier before string constant > 9 | #define REG_OUT "a" > | ^~~ Perhaps REG_{OUT,IN} in arch/x86/include/asm/arch_hweight.h should be renamed instead, as this is a generic header file that can be included anywhere, while the REG_{OUT,IN} definitions are only used locally, in the header file? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds