Hi Andy, andriy.shevchenko@xxxxxxxxxxxxxxx wrote on Tue, 29 Mar 2022 19:01:14 +0300: > On Tue, Mar 29, 2022 at 05:24:20PM +0200, Miquel Raynal wrote: > > Hello, > > > > Support for the RZN1 DMA engine allows us adapt a little bit the 8250 DW > > UART driver with to bring DMA support for this SoC. > > > > This short series applies on top of the series bringing RZN1 DMA > > support, currently on its v5, see [1]. Technically speaking, only the DT > > patch needs to be applied after [1]. The other patches can come in at > > any moment, because if no "dmas" property is provided in the DT, DMA > > support will simply be ignored. > > > > [1] https://lore.kernel.org/dmaengine/20220315191255.221473-1-miquel.raynal@xxxxxxxxxxx/T/#m0ef3323abce3eec961e142bf2fb35e95b9045fc5 > > Thanks for a new version! > > It becomes definitely closer to the good enough state. > Since I have comments and we still in the middle of the merge window > we have time to address them. Yes sure, thanks for your quick feedback. I'll propose an updated version with: - Empty pdata structures for all the compatibles (only one will remain at the end) in order to avoid the "if (pdata)" checks. - Save the pdata pointer once for all and use derive it directly everywhere else. BTW, you may probably send your Reviewed-by to the DMA series which was sent a couple of weeks back if you don't have more comments on it? Thanks, Miquèl
