On Thu, Mar 10, 2022 at 05:16:48PM +0100, Miquel Raynal wrote: > From: Phil Edworthy <phil.edworthy@xxxxxxxxxxx> > > The CPR register can give the information whether the IP is DMA capable > or not. Let's extract this information and use it to discriminate when > the DMA can be hooked up or not. ... > + /* If we have a valid fifosize and DMA support, try hooking up DMA */ > + if (p->fifosize && data->dma_capable) { > + if (reg & DW_UART_CPR_DMA_EXTRA) > + data->dma_capable = 1; How many designs will be broken by this change? ... > + unsigned int dma_capable:1; Note, we use up->dma == NULL for no-DMA, no additional flag is needed. Just make sure that for your platform you enable DMA by filling that. -- With Best Regards, Andy Shevchenko