Hi,
On Fri, Mar 4, 2022 at 7:46 AM Kieran Bingham
<kieran.bingham@xxxxxxxxxxxxxxxx> wrote:
>
> > > What about:
> > >
> > > pdata->no_hpd = of_property_read_bool(np, "no-hpd");
> > > if (panel && !pdata->no_hpd) {
> > > DRM_ERROR("Panels will not function with HPD. Enforcing no-hpd\n");
> > > pdata->no_hpd = true;
> > > }
> > >
> > > That leaves it still optional to DP connectors, but enforced on eDP?
> >
> > Yeah, that's fine with me. Nits would be to use "warn" instead of
> > "error" since this isn't fatal and use the non-SHOUTING versions of
> > the prints since the SHOUTING versions are deprecated.
>
> Could you clarify this please? The whole driver uses DRM_ERROR style. Is
> there a new debug macro somewhere?
Mostly looking at commit 306589856399 ("drm/print: Add deprecation
notes to DRM_...() functions"), which I added a few months ago.
Despite the fact that I added the documentation, though, I'm not the
one driving the transition away from the SHOUTing versions. If you
look through history you can see this is driven by more senior DRM
people.
IMO it's fine to transition slowly to the new non-shouting versions
and it doesn't bother me to have some code in a file using the old
SHOUTing versions and some using the newer functions. Basically for
new code or when we're touching code anyway we do the transition then.
That being said, if you want to
-Doug
