Re: [PATCH V2 2/7] soc: renesas: Identify RZ/G2UL SoC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Biju,

On Thu, Mar 3, 2022 at 5:26 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> Add support for identifying the RZ/G2UL (R9A07G043U) SoC.
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>

Thanks for your patch!

> --- a/drivers/soc/renesas/Kconfig
> +++ b/drivers/soc/renesas/Kconfig
> @@ -296,6 +296,12 @@ config ARCH_R8A774B1
>         help
>           This enables support for the Renesas RZ/G2N SoC.
>
> +config ARCH_R9A07G043U

Likewise (cfr. my comments on 1/7), I think this should use
ARCH_R9A07G043 instead.

> +       bool "ARM64 Platform support for RZ/G2UL"
> +       select ARCH_RZG2L
> +       help
> +         This enables support for the Renesas RZ/G2UL SoC variants.
> +
>  config ARCH_R9A07G044
>         bool "ARM64 Platform support for RZ/G2L"
>         select ARCH_RZG2L
> diff --git a/drivers/soc/renesas/renesas-soc.c b/drivers/soc/renesas/renesas-soc.c
> index 92c7b42250ee..c667baf4fc59 100644
> --- a/drivers/soc/renesas/renesas-soc.c
> +++ b/drivers/soc/renesas/renesas-soc.c
> @@ -64,6 +64,10 @@ static const struct renesas_family fam_rzg2l __initconst __maybe_unused = {
>         .name   = "RZ/G2L",
>  };
>
> +static const struct renesas_family fam_rzg2ul __initconst __maybe_unused = {
> +       .name   = "RZ/G2UL",
> +};
> +
>  static const struct renesas_family fam_rzv2l __initconst __maybe_unused = {
>         .name   = "RZ/V2L",
>  };
> @@ -148,6 +152,11 @@ static const struct renesas_soc soc_rz_g2l __initconst __maybe_unused = {
>         .id     = 0x841c447,
>  };
>
> +static const struct renesas_soc soc_rz_g2ul __initconst __maybe_unused = {
> +       .family = &fam_rzg2ul,
> +       .id     = 0x8450447,

Rev. 0.51 of the RZ/G2UL Hardware User's Manual still lists the same
ID as RZ/G2L, so I can't check this :-(

> +};
> +
>  static const struct renesas_soc soc_rz_v2l __initconst __maybe_unused = {
>         .family = &fam_rzv2l,
>         .id     = 0x8447447,
> @@ -340,6 +349,9 @@ static const struct of_device_id renesas_socs[] __initconst = {
>  #ifdef CONFIG_ARCH_R8A779F0
>         { .compatible = "renesas,r8a779f0",     .data = &soc_rcar_s4 },
>  #endif
> +#if defined(CONFIG_ARCH_R9A07G043U)
> +       { .compatible = "renesas,r9a07g043u11", .data = &soc_rz_g2ul },

 "renesas,r9a07g043", so it catches both Type-1 and Type-2 SoCs?

> +#endif
>  #if defined(CONFIG_ARCH_R9A07G044)
>         { .compatible = "renesas,r9a07g044",    .data = &soc_rz_g2l },
>  #endif

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux