Hi Kieran, On Mon, Feb 28, 2022 at 12:29:14PM +0000, Kieran Bingham wrote: > Quoting Laurent Pinchart (2022-02-28 11:29:01) > > YUV formats can be subsampled, which interact with cropping. Add a test > > to verify that the VSP driver handles this correctly. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > --- > > tests/vsp-unit-test-0027.sh | 46 +++++++++++++++++++++++++++++++++++++ > > 1 file changed, 46 insertions(+) > > create mode 100755 tests/vsp-unit-test-0027.sh > > > > diff --git a/tests/vsp-unit-test-0027.sh b/tests/vsp-unit-test-0027.sh > > new file mode 100755 > > index 000000000000..8be8ae736375 > > --- /dev/null > > +++ b/tests/vsp-unit-test-0027.sh > > @@ -0,0 +1,46 @@ > > +#!/bin/sh > > +# SPDX-License-Identifier: GPL-2.0-or-later > > +# SPDX-FileCopyrightText: 2017-2022 Renesas Electronics Corporation > > + > > +# > > +# Test RPF crop using multiplanar YUV formats, test buffer offset calculation > > +# with subsampling. Use a RPF -> WPF pipeline, passing a selection of cropping > > +# windows. > > +# > > + > > +. ./vsp-lib.sh > > + > > +features="rpf.0 wpf.0" > > +crops="(0,0)/512x384 (32,32)/512x384 (32,64)/512x384 (64,32)/512x384" > > I was expecting to see more strenuous variations here. Are the crops > limited for now ? I've copied these values from the RGB crop tests. We can add more crop rectangles if there are specific items that need to be tested. > Does this already highlight any failures in the > driver? or do these pass? The test fails, the fix is available at https://lore.kernel.org/linux-media/20220228120058.9755-1-laurent.pinchart+renesas@xxxxxxxxxxxxxxxx/T/#u > Anyway, Extending the tests is beneficial, even if this can be further > extended. > > Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> > > > +formats="NV12M NV16M YUV420M YUV422M YUV444M" > > + > > +test_rpf_cropping() { > > + local format=$1 > > + local crop=$2 > > + > > + test_start "RPF crop from $crop in $format" > > + > > + pipe_configure rpf-wpf 0 0 > > + format_configure rpf-wpf 0 0 $format 1024x768 YUV444M --rpfcrop=$crop > > + > > + vsp_runner rpf.0 & > > + vsp_runner wpf.0 > > + > > + local result=$(compare_frames crop=${crop}) > > + > > + test_complete $result > > +} > > + > > +test_main() { > > + local crop > > + local format > > + > > + for format in $formats ; do > > + for crop in $crops ; do > > + test_rpf_cropping $format $crop > > + done > > + done > > +} > > + > > +test_init $0 "$features" > > +test_run -- Regards, Laurent Pinchart
