Quoting Laurent Pinchart (2021-12-29 19:31:33)
> The Mitsubishi AA1024XD12 panel can be used for R-Car Gen2 and Gen3
> boards as an optional external panel. It is described in the
> arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi file as a direct child of the
> DT root node. This allows including r8a77xx-aa104xd12-panel.dtsi in
> board device trees, with other minor modifications, to enable the panel.
>
> This is however not how external components should be modelled. Instead
> of modifying the board device tree to enable the panel, it should be
> compiled as a DT overlay, to be loaded by the boot loader.
>
> Prepare the r8a77xx-aa104xd12-panel.dtsi file for this usage by
> declaring a panel node only, without hardcoding its path. Overlay
> sources can then include r8a77xx-aa104xd12-panel.dtsi where appropriate.
>
> This change doesn't cause any regression as r8a77xx-aa104xd12-panel.dtsi
> is currently unused. As overlay support for this panel has only been
> tested with Gen3 hardware, and Gen2 support will require more
> development, move the file to arch/arm64/boot/dts/renesas/.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> ---
> .../arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi | 39 -------------------
> .../boot/dts/renesas/panel-aa104xd12.dtsi | 30 ++++++++++++++
> 2 files changed, 30 insertions(+), 39 deletions(-)
> delete mode 100644 arch/arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi
> create mode 100644 arch/arm64/boot/dts/renesas/panel-aa104xd12.dtsi
>
> diff --git a/arch/arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi b/arch/arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi
> deleted file mode 100644
> index 79fce67ebb1c..000000000000
> --- a/arch/arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi
> +++ /dev/null
> @@ -1,39 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0
> -/*
> - * Common file for the AA104XD12 panel connected to Renesas R-Car boards
> - *
> - * Copyright (C) 2014 Renesas Electronics Corp.
> - */
> -
> -/ {
> - panel {
> - compatible = "mitsubishi,aa104xd12", "panel-lvds";
> -
> - width-mm = <210>;
> - height-mm = <158>;
> - data-mapping = "jeida-18";
> -
> - panel-timing {
> - /* 1024x768 @65Hz */
> - clock-frequency = <65000000>;
> - hactive = <1024>;
> - vactive = <768>;
> - hsync-len = <136>;
> - hfront-porch = <20>;
> - hback-porch = <160>;
> - vfront-porch = <3>;
> - vback-porch = <29>;
> - vsync-len = <6>;
> - };
> -
> - port {
> - panel_in: endpoint {
> - remote-endpoint = <&lvds_connector>;
> - };
> - };
> - };
> -};
> -
> -&lvds_connector {
> - remote-endpoint = <&panel_in>;
> -};
> diff --git a/arch/arm64/boot/dts/renesas/panel-aa104xd12.dtsi b/arch/arm64/boot/dts/renesas/panel-aa104xd12.dtsi
> new file mode 100644
> index 000000000000..6e9f447d8fe1
> --- /dev/null
> +++ b/arch/arm64/boot/dts/renesas/panel-aa104xd12.dtsi
Is this a device directly on the renesas board itself? I still wonder if
'extra' overlays should be in a subfolder here, or ... even potentially
some more common location - but this can do for now I guess.
And I see I gave this on v1, but /after/ you posted v2 ;-)
You can keep it though ...
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
> @@ -0,0 +1,30 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Common file for the AA104XD12 panel connected to Renesas R-Car Gen3 boards.
> + *
> + * Copyright (C) 2021 Renesas Electronics Corp.
> + */
> +
> +panel {
> + compatible = "mitsubishi,aa104xd12", "panel-lvds";
> +
> + width-mm = <210>;
> + height-mm = <158>;
> + data-mapping = "jeida-18";
> +
> + panel-timing {
> + /* 1024x768 @65Hz */
> + clock-frequency = <65000000>;
> + hactive = <1024>;
> + vactive = <768>;
> + hsync-len = <136>;
> + hfront-porch = <20>;
> + hback-porch = <160>;
> + vfront-porch = <3>;
> + vback-porch = <29>;
> + vsync-len = <6>;
> + };
> +
> + port {
> + };
> +};
> --
> Regards,
>
> Laurent Pinchart
>
