Hi Geert,
> Subject: Re: [PATCH v5] clk: renesas: rzg2l-cpg: Add support for RZ/V2L
> SoC
>
> Hi Biju,
>
> On Mon, Feb 7, 2022 at 3:35 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> wrote:
> > > Subject: Re: [PATCH v5] clk: renesas: rzg2l-cpg: Add support for
> > > RZ/V2L SoC On Sat, Feb 5, 2022 at 9:40 AM Biju Das
> > > <biju.das.jz@xxxxxxxxxxxxxx>
> > > wrote:
> > > > The clock structure for RZ/V2L is almost identical to RZ/G2L SoC.
> > > > The only difference being RZ/V2L has an additional registers to
> > > > control clock and reset for the DRP-AI block.
> > > >
> > > > This patch reuses r9a07g044-cpg.c, as the common clock IDS and
> > > > rest IDS are same between RZ/G2L and RZ/V2L and adding a separate
> > > > r9a07g054_cpg_info to take care of DRP-AI clocks/resets.
> > > >
> > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > > > Signed-off-by: Lad Prabhakar
> > > > <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> > > > --- a/drivers/clk/renesas/r9a07g044-cpg.c
> > > > +++ b/drivers/clk/renesas/r9a07g044-cpg.c
>
> > > > @@ -80,252 +81,285 @@ static const char * const sel_pll6_2[] = {
> > > ".pll6_250", ".pll5_250" };
> > > > static const char * const sel_shdi[] = { ".clk_533", ".clk_400",
> > > > ".clk_266" }; static const char * const sel_gpu2[] = { ".pll6",
> > > > ".pll3_div2_2" };
> > > >
> > > > -static const struct cpg_core_clk r9a07g044_core_clks[] __initconst
> = {
> > > > - /* External Clock Inputs */
> > > > - DEF_INPUT("extal", CLK_EXTAL),
> > > > +static struct {
> > > > + const struct cpg_core_clk common[44]; #ifdef
> > > > +CONFIG_CLK_R9A07G054
> > > > + const struct cpg_core_clk drp[0]; #endif } const core_clks
> > > > +__initconst = {
> > >
> > > Having a single "const" between "static" and "struct" is sufficient.
> >
> > I got a check patch error "ERROR: Use of const init definition must use
> __initconst"
> > Which is fixed by "const core_clks __initconst". Looks like checkpatch
> needs this in one line.
>
> Checkpatch is not a full C source parser, and is confused by the
> #ifdef/#endif block, and by the combination of struct definition and
> declaration.
Ok. Good to know that.
Cheers,
Biju
