Hi Geert,
Thanks for the patch.
> Subject: [PATCH] soc: renesas: Insert "Rev" before printed revision on
> RZ/G2L
>
> While just storing the RZ/G2L revision number into the
> soc_device_attribute.revision field is fine, printing only the number
> during boot-up looks a bit silly.
>
> Make the output more visually-pleasing by re-inserting "Rev" on RZ/G2L.
>
> Impact:
>
> -Detected Renesas RZ/G2L r9a07g044 1
> +Detected Renesas RZ/G2L r9a07g044 Rev 1
>
> Reported-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> Fixes: 92dfff382af0ce65 ("soc: renesas: Add support for reading product
> revision for RZ/G2L family")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Tested-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> ---
> To be folded into the original commit.
>
> Compared to my earlier proposal, this does not impact the output on non-
> RZ/G2L SoCs.
> ---
> drivers/soc/renesas/renesas-soc.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/renesas/renesas-soc.c
> b/drivers/soc/renesas/renesas-soc.c
> index 1ca83c4c0fd8c9e5..a5377d9c299f6c48 100644
> --- a/drivers/soc/renesas/renesas-soc.c
> +++ b/drivers/soc/renesas/renesas-soc.c
> @@ -408,6 +408,7 @@ static int __init renesas_soc_init(void)
> const struct renesas_soc *soc;
> const struct renesas_id *id;
> void __iomem *chipid = NULL;
> + const char *rev_prefix = "";
> struct soc_device *soc_dev;
> struct device_node *np;
> const char *soc_id;
> @@ -463,6 +464,7 @@ static int __init renesas_soc_init(void)
> eshi = ((product >> 28) & 0x0f);
> soc_dev_attr->revision = kasprintf(GFP_KERNEL, "%u",
> eshi);
> + rev_prefix = "Rev ";
> }
>
> if (soc->id &&
> @@ -472,8 +474,8 @@ static int __init renesas_soc_init(void)
> }
> }
>
> - pr_info("Detected Renesas %s %s %s\n", soc_dev_attr->family,
> - soc_dev_attr->soc_id, soc_dev_attr->revision ?: "");
> + pr_info("Detected Renesas %s %s %s%s\n", soc_dev_attr->family,
> + soc_dev_attr->soc_id, rev_prefix, soc_dev_attr->revision ?:
> "");
>
> soc_dev = soc_device_register(soc_dev_attr);
> if (IS_ERR(soc_dev)) {
> --
> 2.25.1
