Hi Geert,
Thanks for the feedback.
> Subject: Re: [PATCH 1/4] arm64: dts: renesas: rzg2l-smarc: Add common dtsi
> file
>
> Hi Biju, Prabhakar,
>
> On Wed, Jan 19, 2022 at 10:52 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> wrote:
> > RZ/G2L and RZ/G2LC SoC use the same carrier board, but the SoM is
> > different.
> >
> > Different pin mapping is possible on SoM. For eg:- RZ/G2L SMARC EVK
> > uses SCIF2, whereas RZ/G2LC uses SCIF1 for the serial interface
> > available on PMOD1.
> >
> > This patch adds support for handling the pin mapping differences by
> > moving definitions common to RZ/G2L and RZ/G2LC to a common dtsi file.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/r9a07g044c2-smarc.dts
> > +++ b/arch/arm64/boot/dts/renesas/r9a07g044c2-smarc.dts
>
> > @@ -66,11 +65,6 @@
> > status = "disabled";
> > };
> >
> > -&scif2 {
> > - /delete-property/ pinctrl-0;
>
> In the meantime, one more line for pinctrl-names should be deleted.
>
> > - status = "disabled";
> > -};
> > -
> > &spi1 {
> > /delete-property/ pinctrl-0;
> > status = "disabled";
>
> The rest LGTM, so
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> > --- a/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi
> > @@ -1,6 +1,6 @@
> > // SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > /*
> > - * Device Tree Source for the RZ/G2L SMARC EVK common parts
> > + * Device Tree Source for the RZ/G2L SMARC EVK parts
> > *
> > * Copyright (C) 2021 Renesas Electronics Corp.
> > */
>
> Note that the above conflicts with "[PATCH v2 11/12] arm64: dts:
> renesas: Add initial device tree for RZ/V2L SMARC EVK"[1], which I had
> queued in renesas-devel, but dropped again due to a missing dependency on
> the clock bindings include file. In the meantime, the updated clock
> bindings include file is ready.
>
> So, which one has the highest priority: this series, or RZ/V2L?
V2L is higher priority. I will rebase and send V2.
Cheers,
Biju
>
> [1]
> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.ker
> nel.org%2Fall%2F20220110134659.30424-12-prabhakar.mahadev-
> lad.rj%40bp.renesas.com%2F&data=04%7C01%7Cbiju.das.jz%40bp.renesas.com
> %7Cf50386cff0f44f8bd06a08d9e5a27b0b%7C53d82571da1947e49cb4625a166a4a2a%7C0
> %7C0%7C637793308284273842%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQ
> IjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=lGdj6Cp4XNNQbY
> scJPxGcaw6u1v34Bp0P6cTY7WxUN8%3D&reserved=0
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
> -- Linus Torvalds
