Re: [RFC 05/28] clk: renesas: r9a07g044: Add {M2, M2_DIV2} Clocks support

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

On Wed, Jan 12, 2022 at 6:46 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> Add support for {M2, M2_DIV2} clocks which is sourced from pll3_533.
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

> --- a/drivers/clk/renesas/r9a07g044-cpg.c
> +++ b/drivers/clk/renesas/r9a07g044-cpg.c
> @@ -54,6 +54,7 @@ enum clk_ids {
>         CLK_SD1_DIV4,
>         CLK_SEL_GPU2,
>         CLK_SEL_PLL5_4,
> +       CLK_M2_DIV2,

Shouldn't this be inserted closer to its parent?

>
>         /* Module Clocks */
>         MOD_CLK_BASE,

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds