On Tue, Feb 1, 2022 at 3:00 AM Sergey Shtylyov <s.shtylyov@xxxxxx> wrote: > ravb_close() always returns 0, hence the check in ravb_wol_restore() is > pointless (however, we cannot change the prototype of ravb_close() as it > implements the driver's ndo_stop() method). > > Found by Linux Verification Center (linuxtesting.org) with the SVACE static > analysis tool. > > Signed-off-by: Sergey Shtylyov <s.shtylyov@xxxxxx> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds