Hi Nikita,
On Sat, Dec 25, 2021 at 12:54 PM Nikita Yushchenko
<nikita.yoush@xxxxxxxxxxxxxxxxxx> wrote:
> This patch adds nodes needed to enable DRM video output over HDMI
> connector located on KF board.
>
> Signed-off-by: Nikita Yushchenko <nikita.yoush@xxxxxxxxxxxxxxxxxx>
Thanks for your patch!
> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> @@ -51,6 +51,31 @@ wlan_en: regulator-wlan_en {
> startup-delay-us = <70000>;
> enable-active-high;
> };
> +
> + hdmi_1v8: regulator-hdmi-1v8 {
> + compatible = "regulator-fixed";
> + regulator-name = "hdmi-1v8";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + };
> +
> + hdmi_3v3: regulator-hdmi-3v3 {
> + compatible = "regulator-fixed";
> + regulator-name = "hdmi-3v3";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + };
> +
> + hdmi1-out {
Sort order.
> + compatible = "hdmi-connector";
> + type = "a";
> +
> + port {
> + hdmi1_con: endpoint {
> + remote-endpoint = <&adv7513_out>;
> + };
> + };
> + };
> };
>
> &can0 {
> @@ -236,6 +313,10 @@ gpio_exp_77: gpio@77 {
> };
> };
>
> +&du_out_rgb {
Sort order.
> + remote-endpoint = <&adv7513_in>;
> +};
> +
> &ohci0 {
> dr_mode = "otg";
> status = "okay";
> @@ -289,6 +370,18 @@ usb0_pins: usb0 {
> groups = "usb0";
> function = "usb0";
> };
> +
> + hdmi1_pins: hdmi1 {
> + du {
More sort order.
> + groups = "du_rgb888", "du_sync", "du_clk_out_0", "du_disp";
> + function = "du";
> + };
> +
> + adv7513-interrupt {
> + pins = "GP_2_14";
> + bias-pull-up;
> + };
> + };
> };
The rest looks good to me.
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
i.e. will queue in renesas-devel for v5.18 with the sort order fixed.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
