Hi Cezary, On Wed, Jan 19, 2022 at 2:12 PM Cezary Rojewski <cezary.rojewski@xxxxxxxxx> wrote: > > On 2022-01-15 2:22 AM, Lad Prabhakar wrote: > > Hi All, > > > > This patch series does code cleanup and fixes to the rz-ssi driver. > > Hello, > > Suggestion for the future contributions below. My input is *not* to be > treated as a blocker for the series and is not a reason for re-sending it. > > > Cover letter should provide a high-level view of the series. That > includes but is not limited to the overall layout of the series. Here, > it would be good to state why the fixes are made. Also, it is preferred > to have the fixes leading the series, _before_ any cleanups. > > This summary suggests that cleanups are leading the series instead. > Think of cover-letter as of news-paper. Subsystem maintainers such as > Mark and Takashi start here (read the first page first) to get the > general idea of what the contributor is sending them. Being transparent > only helps. Good descriptions also helps reviewers to know which patches > to look at first. Fixes are obviously of more importance as they usually > address issues troubling users of the release-builds. Such patches are > also often backported down the stream, increasing the importance for > their review. > > There's more to it, but for the scope of this cover letter, this should > suffice. It's just a suggestion but I hope you find it useful. > > Thank you for the valuable input. I'll make a note of it and make sure to add more information in cover letters too. Cheers, Prabhakar
