On 2022-01-15 2:22 AM, Lad Prabhakar wrote:
Instead of recursively calling rz_ssi_pio_recv() use a loop instead
to read the samples from RX fifo.
Inspiration for this patch is to avoid recursion, as recursion is
unwelcome in kernel due to limited stack use. Also to add this driver
will later be used on RZ/A2 SoC's which runs with limited memory.
This also fixes an issue where the return value of rz_ssi_pio_recv()
was ignored when called recursively.
Fixes: 03e786bd4341 ("ASoC: sh: Add RZ/G2L SSIF-2 driver")
Reported-by: Pavel Machek <pavel@xxxxxxx>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
Reviewed-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
---
v1->v2
* Used a do while loop
* Fixed comments pointed by Cezary.
Apart from my previous suggestions which have already been addressed, I
don't see any issues with the patch, so:
Reviewed-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx>
Regards,
Czarek
