Re: [PATCH RFC] phy: make phy_set_max_speed() *void*

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/18/22 1:08 AM, Andrew Lunn wrote:

>> After following the call tree of phy_set_max_speed(), it became clear
>> that this function never returns anything but 0, so we can change its
>> result type to *void* and drop the result checks from the three drivers
>> that actually bothered to do it...
>>
>> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
>> analysis tool.
>>
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@xxxxxx>
> 
> Seems reasonable.

   No need to seprate into severla patches? :-)

> net-next is closed at the moment, so please repost

   That's why RFC is mainly here. :-)

> once it opens.

   Sure.

> Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

   T!

>     Andrew

MBR, Sergey



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux