Hi Laurent,
Quoting Laurent Pinchart (2021-12-12 01:33:50)
> The Salvator-X and Salvator-XS boards support an optional LVDS panel.
> One compatible panel is the Mitsubishi AA104XD12. Add a corresponding DT
> overlay.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/renesas/Makefile | 2 ++
> .../dts/renesas/salvator-panel-aa104xd12.dts | 32 +++++++++++++++++++
> 2 files changed, 34 insertions(+)
> create mode 100644 arch/arm64/boot/dts/renesas/salvator-panel-aa104xd12.dts
>
> diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile
> index d1c5c21d8d14..982ca3e0e86f 100644
> --- a/arch/arm64/boot/dts/renesas/Makefile
> +++ b/arch/arm64/boot/dts/renesas/Makefile
> @@ -74,3 +74,5 @@ dtb-$(CONFIG_ARCH_R8A77961) += r8a779m3-ulcb-kf.dtb
> dtb-$(CONFIG_ARCH_R8A77965) += r8a779m5-salvator-xs.dtb
>
> dtb-$(CONFIG_ARCH_R9A07G044) += r9a07g044l2-smarc.dtb
> +
> +dtb-$(CONFIG_ARCH_RCAR_GEN3) += salvator-panel-aa104xd12.dtbo
dts/renesas/ is quite busy with platform support already. If overlays
are added which could theoretically be anynumber of external devices ...
should they be under a sub-directory here? I think it would make make
overlays both easier to identify, and easier to find.
> diff --git a/arch/arm64/boot/dts/renesas/salvator-panel-aa104xd12.dts b/arch/arm64/boot/dts/renesas/salvator-panel-aa104xd12.dts
> new file mode 100644
> index 000000000000..ca2d579fe42f
> --- /dev/null
> +++ b/arch/arm64/boot/dts/renesas/salvator-panel-aa104xd12.dts
> @@ -0,0 +1,32 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Device Tree overlay for the AA104XD12 panel connected to LVDS0 on a
> + * Salvator-X or Salvator-XS board
> + *
> + * Copyright 2021 Ideas on Board Oy
> + */
> +
> +/dts-v1/;
> +/plugin/;
> +
> +&{/} {
> +#include "panel-aa104xd12.dtsi"
> +};
> +
> +&{/panel} {
> + backlight = <&backlight>;
> +
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&lvds0_out>;
Of course, overlay are always going to be very platform specific though
...
Which I guess is why you have the panel itself broken out which seems
like a good idea, as that could then be used by multiple platoforms? (at
least within the renesas structure so far)
Seems like overlays are still a pain ;-)
> + };
> + };
> +};
> +
> +&lvds0 {
> + status = "okay";
> +};
> +
> +&lvds0_out {
> + remote-endpoint = <&panel_in>;
> +};
> --
> Regards,
>
> Laurent Pinchart
>
