Hi Biju, On Thu, Dec 16, 2021 at 12:43 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote: > Add basic support for RZ/G2LC SMARC EVK (based on R9A07G044C2): > - memory > - External input clock > - SCIF > - GbEthernet > - Audio Clock > > It shares the same carrier board with RZ/G2L, but the pin mapping is > different. Disable the device nodes which is not tested and > delete the corresponding pinctrl definitions. > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> Thanks for your patch! Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Before I queue this in renesas-devel for v5.18, I have two questions: > --- /dev/null > +++ b/arch/arm64/boot/dts/renesas/r9a07g044c2-smarc.dts > @@ -0,0 +1,99 @@ > +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +/* > + * Device Tree Source for the RZ/G2LC SMARC EVK board > + * > + * Copyright (C) 2021 Renesas Electronics Corp. > + */ > + > +/dts-v1/; > +#include "r9a07g044c2.dtsi" > +#include "rzg2lc-smarc-som.dtsi" > +#include "rzg2lc-smarc-pinfunction.dtsi" 1) So far it looks like the definitions in rzg2lc-smarc-pinfunction.dtsi do not really differ from those in rzg2l-smarc-pinfunction.dtsi,\ there are just less. Will there be other differences? 2) Would it make sense to create rzg2*-smarc-som-pinfunction.dtsi files, too? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds