On Tue, Jan 4, 2022 at 5:36 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote: > > The driver overrides the error code returned by devm_request_irq() to > -ENOENT. Switch to propagating the error code upstream. Thanks, FWIW, Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > Suggested-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > --- > This patch depends on [1]. > > [1] https://lkml.org/lkml/2021/12/22/633 > --- > drivers/gpio/gpio-rcar.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c > index 437baecc434e..bd2e16d6e21c 100644 > --- a/drivers/gpio/gpio-rcar.c > +++ b/drivers/gpio/gpio-rcar.c > @@ -552,10 +552,10 @@ static int gpio_rcar_probe(struct platform_device *pdev) > goto err0; > } > > - if (devm_request_irq(dev, p->irq_parent, gpio_rcar_irq_handler, > - IRQF_SHARED, name, p)) { > + ret = devm_request_irq(dev, p->irq_parent, gpio_rcar_irq_handler, > + IRQF_SHARED, name, p); > + if (ret) { > dev_err(dev, "failed to request IRQ\n"); > - ret = -ENOENT; > goto err1; > } > > -- > 2.17.1 > -- With Best Regards, Andy Shevchenko
