Hi Miquel, I love your patch! Yet something to improve: [auto build test ERROR on mtd/nand/next] [also build test ERROR on geert-renesas-devel/next mtd/mtd/next mtd/mtd/fixes linus/master v5.16-rc5 next-20211214] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Miquel-Raynal/Renesas-RZ-N1-NAND-controller-support/20211215-234825 base: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20211216/202112160417.TvfPZeKJ-lkp@xxxxxxxxx/config) compiler: sh4-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/4899a382aebedd2033aba1a8c662767c86c8d74d git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Miquel-Raynal/Renesas-RZ-N1-NAND-controller-support/20211215-234825 git checkout 4899a382aebedd2033aba1a8c662767c86c8d74d # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sh SHELL=/bin/bash drivers/mtd/nand/raw/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): In file included from drivers/mtd/nand/raw/rzn1-nand-controller.c:14: >> drivers/mtd/nand/raw/rzn1-nand-controller.c:1408:25: error: 'nandc_id_table' undeclared here (not in a function); did you mean 'rzn1_nandc_id_table'? 1408 | MODULE_DEVICE_TABLE(of, nandc_id_table); | ^~~~~~~~~~~~~~ include/linux/module.h:244:15: note: in definition of macro 'MODULE_DEVICE_TABLE' 244 | extern typeof(name) __mod_##type##__##name##_device_table \ | ^~~~ >> include/linux/module.h:244:21: error: '__mod_of__nandc_id_table_device_table' aliased to undefined symbol 'nandc_id_table' 244 | extern typeof(name) __mod_##type##__##name##_device_table \ | ^~~~~~ drivers/mtd/nand/raw/rzn1-nand-controller.c:1408:1: note: in expansion of macro 'MODULE_DEVICE_TABLE' 1408 | MODULE_DEVICE_TABLE(of, nandc_id_table); | ^~~~~~~~~~~~~~~~~~~ vim +1408 drivers/mtd/nand/raw/rzn1-nand-controller.c 1403 1404 static const struct of_device_id rzn1_nandc_id_table[] = { 1405 { .compatible = "renesas,rzn1-nand-controller" }, 1406 {} /* sentinel */ 1407 }; > 1408 MODULE_DEVICE_TABLE(of, nandc_id_table); 1409 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
