Hi Geert,
Thanks for your work, I learnt something new.
On 2021-12-08 11:32:07 +0100, Geert Uytterhoeven wrote:
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> Use the dev_err_probe() helper, instead of open-coding the same
> operation.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
> drivers/net/ethernet/renesas/sh_eth.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index 223626290ce0e278..d947a628e1663009 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -3368,8 +3368,7 @@ static int sh_eth_drv_probe(struct platform_device *pdev)
> /* MDIO bus init */
> ret = sh_mdio_init(mdp, pd);
> if (ret) {
> - if (ret != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "MDIO init failed: %d\n", ret);
> + dev_err_probe(&pdev->dev, ret, "MDIO init failed\n");
> goto out_release;
> }
>
> --
> 2.25.1
>
--
Kind Regards,
Niklas Söderlund
