Hi Philipp,
Thanks for the feedback.
> Subject: Re: [PATCH v3 2/2] thermal/drivers: Add TSU driver for RZ/G2L
>
> Hi Biju,
>
> On Tue, 2021-11-30 at 15:57 +0000, Biju Das wrote:
> > The RZ/G2L SoC incorporates a thermal sensor unit (TSU) that measures
> > the temperature inside the LSI.
> >
> > The thermal sensor in this unit measures temperatures in the range
> > from
> > −40 degree Celsius to 125 degree Celsius with an accuracy of ±3°C. The
> > TSU repeats measurement at 20 microseconds intervals and automatically
> > updates the results of measurement.
> >
> > The TSU has no interrupts as well as no external pins.
> >
> > This patch adds Thermal Sensor Unit(TSU) driver for RZ/G2L SoC.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > ---
> [...]
> > +static int rzg2l_thermal_probe(struct platform_device *pdev) {
> [...]
> > + priv->rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);
> ^^^^^^^^^^ Could use
> dev here.
>
> > + if (IS_ERR(priv->rstc))
> > + return dev_err_probe(dev, PTR_ERR(priv->rstc),
> > + "failed to get cpg reset");
> > +
> > + reset_control_deassert(priv->rstc);
>
> I'd return if reset_control_deassert() throws an error. Either way,
OK, I will send an incremental patch to address the above 2 comments, as this patch is already in next[1]
[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20211208&id=673c68bd48390dad01f7d17670de3e33b60860ac
Regards,
Biju
>
> Reviewed-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
>
> regards
> Philipp
