Hi Kieran, Thank you for the patch. On Mon, Nov 29, 2021 at 05:08:45PM +0000, Kieran Bingham wrote: > The DSI output names were not added when the DSI pipeline support was > introduced. > > Add the correct labels for these outputs, and fix the sort order to > match 'enum rcar_du_output' while we are here. > > Fixes: b291fdcf5114 ("drm: rcar-du: Add r8a779a0 device support") > Suggested-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > index 5612a9e7a905..5a8131ef81d5 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -544,10 +544,12 @@ const char *rcar_du_output_name(enum rcar_du_output output) > static const char * const names[] = { > [RCAR_DU_OUTPUT_DPAD0] = "DPAD0", > [RCAR_DU_OUTPUT_DPAD1] = "DPAD1", > - [RCAR_DU_OUTPUT_LVDS0] = "LVDS0", > - [RCAR_DU_OUTPUT_LVDS1] = "LVDS1", > + [RCAR_DU_OUTPUT_DSI0] = "DSI0", > + [RCAR_DU_OUTPUT_DSI1] = "DSI1", > [RCAR_DU_OUTPUT_HDMI0] = "HDMI0", > [RCAR_DU_OUTPUT_HDMI1] = "HDMI1", > + [RCAR_DU_OUTPUT_LVDS0] = "LVDS0", > + [RCAR_DU_OUTPUT_LVDS1] = "LVDS1", > [RCAR_DU_OUTPUT_TCON] = "TCON", > }; > -- Regards, Laurent Pinchart