Hi Sergey Shtylyov, > Subject: Re: [RFC 0/2] Add Rx checksum offload support > > On 11/23/21 4:31 PM, Biju Das wrote: > > > TOE has hw support for calculating IP header checkum for IPV4 and > > TCP/UDP/ICMP checksum for both IPV4 and IPV6. > > > > This patch series aims to adds Rx checksum offload supported by TOE. > > > > For RX, The result of checksum calculation is attached to last 4byte > > of ethernet frames. First 2bytes is result of IPV4 header checksum and > > next 2 bytes is TCP/UDP/ICMP. > > > > if frame does not have error "0000" attached to checksum calculation > > result. For unsupported frames "ffff" is attached to checksum > > calculation result. Cases like IPV6, IPV4 header is always set to > "FFFF". > > > > we can test this functionality by the below commands > > > > ethtool -K eth0 rx on --> to turn on Rx checksum offload ethtool -K > > eth0 rx off --> to turn off Rx checksum offload > > > > Biju Das (2): > > ravb: Fillup ravb_set_features_gbeth() stub > > ravb: Add Rx checksum offload support > > That's all fine but why in the world did you separate these patches? OK, as you suggested will merge this patches and send an RFC for further feedback. Regards, Biju
