Hi Andy,
> > ? Dunno, maybe it is not arbitrary that it is < PAGE_SIZE but other than
> > that the value I chose is arbitrary. There is no technical reason for
> > 2048.
>
> I understand, but the comment is a bit misleading. My proposal is to
> extend / amend the comment to point the upper-upper limit out. Perhaps
> you need to rename "upper" for your case, or use a different word for
> the PAGE_SIZE limit. Up to you.
I use now "upper limit is arbitrary but should be less than PAGE_SIZE".
> > > > + if (ret < 0) {
> > >
> > > > + dev_err(dev, "error naming the GPIOs: %d\n", ret);
> > > > + return ret;
> > > > + }
> > >
> > > Perhaps
> > >
> > > return dev_err_probe() ?
> >
> > Reading strings from DT can be deferred? I don't think so.
>
> There is a new development, i.e. the documentation for dev_err_probe()
> is going to be amended to allow this. But I can't quickly find a patch
> in mailing list with the related discussion.
I still don't get this one, so if there is new development and you have
a pointer, I'd be glad to hear about it. Otherwise we can fix it
incrementally later.
All the best,
Wolfram
Attachment:
signature.asc
Description: PGP signature
