Hi Miquel, CC Gareth On Thu, Nov 18, 2021 at 12:19 PM Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote: > Add a Yaml description for this Renesas NAND controller bindings. > > Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx> Thanks for your patch! > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/renesas,r9a06g032-nand-controller.yaml > @@ -0,0 +1,60 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mtd/renesas,r9a06g032-nand-controller.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas RZ/N1x NAND flash controller device tree bindings > + > +maintainers: > + - Miquel Raynal <miquel.raynal@xxxxxxxxxxx> > + > +allOf: > + - $ref: "nand-controller.yaml" > + > +properties: > + compatible: > + const: renesas,r9a06g032-nand-controller As the NAND Flash Controller is present on all of RZ/N1D, RZ/N1S, and RZ/N1L, I think you should add a family-specific compatible value "renesas,rzn1-nand-controller" as a fallback. > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + > + nand-controller@40102000 { > + compatible = "renesas,r9a06g032-nand-controller"; > + reg = <0x40102000 0x2000>; > + interrupts = <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&hclk_nand>, <&clk_nand>; This clocks property is not based on an actual .dtsi, right? > + clock-names = "hclk", "eclk"; > + #address-cells = <1>; > + #size-cells = <0>; > + }; The rest looks good to me. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
