Hi Geert-san,
Thank you for your review1
> From: Geert Uytterhoeven, Sent: Friday, November 19, 2021 4:04 AM
>
> Hi Shimoda-san,
>
> On Tue, Nov 16, 2021 at 8:42 AM Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> > Add support for identifying the R-Car S4-8 (R8A779F0) SoC.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/drivers/soc/renesas/Kconfig
> > +++ b/drivers/soc/renesas/Kconfig
> > @@ -256,6 +256,13 @@ config ARCH_R8A779A0
> > help
> > This enables support for the Renesas R-Car V3U SoC.
> >
> > +config ARCH_R8A779F0
> > + bool "ARM64 Platform support for R-Car S4-8"
> > + select ARCH_RCAR_GEN3
> > + select SYSC_R8A779F0
> > + help
> > + This enables support for the Renesas R-Car S4-8 SoC.
> > +
>
> Please keep sort order (alphabetical, not by part number).
I'm sorry. I didn't realized that. I'll fix it in v2.
> > config ARCH_R8A774C0
> > bool "ARM64 Platform support for RZ/G2E"
> > select ARCH_RCAR_GEN3
> > diff --git a/drivers/soc/renesas/renesas-soc.c b/drivers/soc/renesas/renesas-soc.c
> > index 7961b0be1850..857a42a82747 100644
> > --- a/drivers/soc/renesas/renesas-soc.c
> > +++ b/drivers/soc/renesas/renesas-soc.c
> > @@ -33,6 +33,11 @@ static const struct renesas_family fam_rcar_gen3 __initconst __maybe_unused = {
> > .reg = 0xfff00044, /* PRR (Product Register) */
> > };
> >
> > +static const struct renesas_family fam_rcar_gen4 __initconst __maybe_unused = {
> > + .name = "R-Car Gen4",
> > + .reg = 0xfff00044, /* PRR (Product Register) */
>
> Please drop ".reg", which is only meant for existing SoCs.
> For new SoCs, we rely on the presence of a "renesas,prr" node in DT.
I got it. I'll fix it in v2.
Best regards,
Yoshihiro Shimoda
