Hi Shimoda-san, On Tue, Nov 16, 2021 at 8:42 AM Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote: > Add all Clock Pulse Generator Core Clock Outputs for the Renesas > R-Car S4-8 (R8A779F0) SoC. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> Thanks for your patch! > --- /dev/null > +++ b/include/dt-bindings/clock/r8a779f0-cpg-mssr.h > @@ -0,0 +1,65 @@ > +/* SPDX-License-Identifier: (GPL-2.0 or MIT) */ > +/* > + * Copyright (C) 2021 Renesas Electronics Corp. > + */ > +#ifndef __DT_BINDINGS_CLOCK_R8A779F0_CPG_MSSR_H__ > +#define __DT_BINDINGS_CLOCK_R8A779F0_CPG_MSSR_H__ > + > +#include <dt-bindings/clock/renesas-cpg-mssr.h> > + > +/* r8a779f0 CPG Core Clocks */ > + > +#define R8A779F0_CLK_ZX 0 > +#define R8A779F0_CLK_ZS 1 > +#define R8A779F0_CLK_ZT 2 > +#define R8A779F0_CLK_ZTR 3 > +#define R8A779F0_CLK_S0D2 4 > +#define R8A779F0_CLK_S0D3 5 > +#define R8A779F0_CLK_S0D4 6 > +#define R8A779F0_CLK_S0D2_MM 7 > +#define R8A779F0_CLK_S0D3_MM 8 > +#define R8A779F0_CLK_S0D4_MM 9 > +#define R8A779F0_CLK_S0D2_RT 10 > +#define R8A779F0_CLK_S0D3_RT 11 > +#define R8A779F0_CLK_S0D4_RT 12 > +#define R8A779F0_CLK_S0D6_RT 13 > +#define R8A779F0_CLK_S0D3_PER 14 > +#define R8A779F0_CLK_S0D6_PER 15 > +#define R8A779F0_CLK_S0D12_PER 16 > +#define R8A779F0_CLK_S0D24_PER 17 > +#define R8A779F0_CLK_S0D2_HSC 18 > +#define R8A779F0_CLK_S0D3_HSC 19 > +#define R8A779F0_CLK_S0D4_HSC 20 > +#define R8A779F0_CLK_S0D6_HSC 21 > +#define R8A779F0_CLK_S0D12_HSC 22 > +#define R8A779F0_CLK_S0D2_CC 23 > +#define R8A779F0_CLK_CL 24 > +#define R8A779F0_CLK_CL16M 25 > +#define R8A779F0_CLK_CL16M_MM 26 > +#define R8A779F0_CLK_CL16M_RT 27 > +#define R8A779F0_CLK_CL16M_PER 28 > +#define R8A779F0_CLK_CL16M_HSC 29 > +#define R8A779F0_CLK_Z0 30 > +#define R8A779F0_CLK_Z1 31 > +#define R8A779F0_CLK_ZB3 32 > +#define R8A779F0_CLK_ZB3D2 33 > +#define R8A779F0_CLK_ZB3D4 34 > +#define R8A779F0_CLK_SDSRC 35 I think we can leave out SDSRC, like on the other SoCs, as it's an internal clock. > +#define R8A779F0_CLK_SD0H 36 > +#define R8A779F0_CLK_SD0 37 > +#define R8A779F0_CLK_RPC 38 > +#define R8A779F0_CLK_RPCD2 39 > +#define R8A779F0_CLK_MSO 40 > +#define R8A779F0_CLK_SASYNCRT 41 > +#define R8A779F0_CLK_SASYNCPERD1 42 > +#define R8A779F0_CLK_SASYNCPERD2 43 > +#define R8A779F0_CLK_SASYNCPERD4 44 > +#define R8A779F0_CLK_DBGSOC_HSC 45 > +#define R8A779F0_CLK_RSW2 46 > +#define R8A779F0_CLK_OSC 47 > +#define R8A779F0_CLK_ZR 48 > +#define R8A779F0_CLK_CPEX 49 > +#define R8A779F0_CLK_CBFUSA 50 > +#define R8A779F0_CLK_R 51 The rest looks good to me. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds