Hi Shimoda-san, On Tue, Nov 16, 2021 at 8:42 AM Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote: > Add device tree bindings documentation for Renesas R-Car S4-8 > Spider CPU and BreakOut boards. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> Thanks for your patch! > --- a/Documentation/devicetree/bindings/arm/renesas.yaml > +++ b/Documentation/devicetree/bindings/arm/renesas.yaml > @@ -317,6 +317,14 @@ properties: > > - description: R-Car S4-8 (R8A779F0) > items: > + - enum: > + - renesas,spider-cpu # Spider CPU board (RTP8A779FASKB0SC2S) > + - const: renesas,r8a779f0 > + > + items: Missing "-" in front of "items:". > + - enum: > + - renesas,spider-breakout # Spider BreakOut board (RTP8A779F0ASKB0SB0S) > + - const: renesas,spider-cpu > - const: renesas,r8a779f0 > > - description: R-Car H3e (R8A779M0) The rest LGTM. Reading[1], I assume "RTP8A779F0ASKB0SP2S" is the part number of the full kit? [1] https://www.renesas.com/us/en/products/automotive-products/automotive-system-chips-socs/rtp8a779f0askb0sp2s-r-car-s4-reference-boardspider Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
