Hi Biju,
On Fri, Nov 12, 2021 at 4:32 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > Subject: Re: [PATCH 1/3] drivers: soc: renesas: Enable RENESAS_OSTM
> > On Wed, Nov 10, 2021 at 9:42 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > wrote:
> > > Enable General Timer Module (a.k.a OSTM) driver support for Renesas
> > > RZ/G2L based platforms.
> > >
> > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> >
> > Thanks for your patch!
> >
> > > --- a/drivers/soc/renesas/Kconfig
> > > +++ b/drivers/soc/renesas/Kconfig
> > > @@ -286,6 +286,7 @@ config ARCH_R8A774B1
> > >
> > > config ARCH_R9A07G044
> > > bool "ARM64 Platform support for RZ/G2L"
> > > + select RENESAS_OSTM
> > > help
> > > This enables support for the Renesas RZ/G2L SoC variants.
> >
> > As RZ/G2L uses the ARM Architected Timer as system timer, enabling the
> > OSTM is not mandatory. Perhaps the RENESAS_OSTM symbol should be made
> > visible instead, so the user can enable it when wanted?
>
> I will do the below change to make RENESAS_OSTM symbol visible.
> Is it ok?
>
> config RENESAS_OSTM
> - bool "Renesas OSTM timer driver" if COMPILE_TEST
> + bool "Renesas OSTM timer driver"
> + depends on ARCH_RENESAS || COMPILE_TEST
LGTM.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
