Hi Prabhakar, On Wed, Nov 10, 2021 at 11:46 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote: > Add helper functions to read/read modify write pin config. > > Switch to use helper functions for pins supporting PIN_CONFIG_INPUT_ENABLE > capabilities. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > Reviewed-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > --- > v2->v3 > * Dropped duplicate masking in rzg2l_read_pin_config > * Dropped port_pin flag > * Dropped spinlocks around read/write You do need the spinlock in the read-modify-write case. No worries, I'll add it back while applying. Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> i.e. will queue in renesas-pinctrl-for-v5.17. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds