Hi Prabhakar,
On Fri, Oct 29, 2021 at 2:44 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote:
> Add support to get/set pin config for GPIO port pins.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> Reviewed-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
Thanks for your patch!
> --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> @@ -495,6 +512,14 @@ static int rzg2l_pinctrl_pinconf_get(struct pinctrl_dev *pctldev,
> port = RZG2L_SINGLE_PIN_GET_PORT(*pin_data);
> cfg = RZG2L_SINGLE_PIN_GET_CFGS(*pin_data);
> bit = RZG2L_SINGLE_PIN_GET_BIT(*pin_data);
> + } else {
> + cfg = RZG2L_GPIO_PORT_GET_CFGS(*pin_data);
> + port = RZG2L_PIN_ID_TO_PORT(_pin);
> + bit = RZG2L_PIN_ID_TO_PIN(_pin);
> + port_pin = true;
Instead of setting this flag, perhaps port should be adjusted?
Then rzg2l_r{ead,mw}_pin_config() don't have to care about that
anymore.
> +
> + if (rzg2l_validate_gpio_pin(pctrl, *pin_data, port, bit))
> + return -EINVAL;
> }
>
> switch (param) {
> @@ -557,6 +582,14 @@ static int rzg2l_pinctrl_pinconf_set(struct pinctrl_dev *pctldev,
> port = RZG2L_SINGLE_PIN_GET_PORT(*pin_data);
> cfg = RZG2L_SINGLE_PIN_GET_CFGS(*pin_data);
> bit = RZG2L_SINGLE_PIN_GET_BIT(*pin_data);
> + } else {
> + cfg = RZG2L_GPIO_PORT_GET_CFGS(*pin_data);
> + port = RZG2L_PIN_ID_TO_PORT(_pin);
> + bit = RZG2L_PIN_ID_TO_PIN(_pin);
> + port_pin = true;
Likewise.
> +
> + if (rzg2l_validate_gpio_pin(pctrl, *pin_data, port, bit))
> + return -EINVAL;
> }
>
> for (i = 0; i < num_configs; i++) {
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
