On 11/7/21 12:11 PM, Krzysztof Wilczyński wrote:
[+CC Randy as he sent a patch to fix the same thing] Hi Marek,Replace __clk_is_enabled() with pm_runtime_suspended(), otherwise the following build error occurs: arm-linux-gnueabi-ld: drivers/pci/controller/pcie-rcar-host.o: in function `rcar_pcie_aarch32_abort_handler': pcie-rcar-host.c:(.text+0xdd0): undefined reference to `__clk_is_enabled' Fixes: a115b1bd3af0 ("PCI: rcar: Add L1 link state fix into data abort hook")Randy sent a patch which aims to fix the same issue, albeit in a slightly different way. I wonder if it would make sense for the two of you to look at which approach should we pick, or even whether we should combine the two into one patch? https://lore.kernel.org/linux-pci/20211107013703.19995-1-rdunlap@xxxxxxxxxxxxx/
Hi, I saw Marek's patch a couple of hours ago. As long as pm_runtime_suspended() is always available, either live or as a stub (and it looks like it is), I don't see any reason for my patch at all. thanks. -- ~Randy
