Hi Kieran, Thanks for your work. On 2021-11-01 17:19:49 +0000, Kieran Bingham wrote: > The MAX9286 has not explicitly declared a dependency upon VIDEO_V4L2. > While this dependency has likely always been met by configurations > including it, the device does use V4L2 core, and should depend upon it. > > Add VIDEO_V4L2 as a dependency to match other drivers and prevent > failures when compile testing. > > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> > > --- > A bit of an RFC almost, as I haven't seen any failure on this, however > this does stand out as different to other drivers, and the recent > "max96712: Select VIDEO_V4L2" posting has shown that these deserialiser > drivers could find themselves being compile tested in a manner which > would other wise break. > --- > drivers/media/i2c/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > index d6a5d4ca439a..9eac5e96c6aa 100644 > --- a/drivers/media/i2c/Kconfig > +++ b/drivers/media/i2c/Kconfig > @@ -468,7 +468,7 @@ config VIDEO_VPX3220 > > config VIDEO_MAX9286 > tristate "Maxim MAX9286 GMSL deserializer support" > - depends on I2C && I2C_MUX > + depends on VIDEO_V4L2 && I2C && I2C_MUX I think the new 'depends on' shall be on a separate line. Reading this is confusing as now the V4L2 is mixed with I2C while GPIO is still on a separate line. > depends on OF_GPIO > select V4L2_FWNODE > select VIDEO_V4L2_SUBDEV_API > -- > 2.30.2 > -- Regards, Niklas Söderlund
