Re: [PATCH] mmc: renesas_sdhi: Fix internal cd irq miss with hard reset

[Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>]

Hi Biju,

> Finally found the issue. There is one more patch for host->reset in tmio_mmc_core.c. please see below.
> If you add this code, then it works.

Thanks for finding the culprit! To get this hopefully into v5.15 still,
I will simply add this chunk like you suggested. However, I really
wonder if we shouldn't just replace this:

>                 /* For R-Car Gen2+, we need to reset SDHI specific SCC */
>                 if (host->pdata->flags & TMIO_MMC_MIN_RCAR2)
>                         host->reset(host);
>  
>                 if (host->native_hotplug)
>                         tmio_mmc_enable_mmc_irqs(host,
>                                 TMIO_STAT_CARD_REMOVE | TMIO_STAT_CARD_INSERT);
>  

with a simple call to

	tmio_mmc_reset(host)

(with tmio_mmc_reset() still updated to set the card interrupts, of
course)? I have to admit I haven't checked all paths for side-effects
yet, but maybe you can already test if this change also works (instead
of adding the second chunk)? If so, we could change it incrementally for
5.16.

Anyhow, will send the patch for 5.15 in some minutes.

Thanks and all the best,

   Wolfram

Attachment: signature.asc
Description: PGP signature