Re: [PATCH v4] soc: renesas: rcar-rst: Add support to set rproc boot address

[Julien Massot <julien.massot@xxxxxxx>]

Hi Geert,


> > +/*
> > + * Most of the R-Car Gen3 SoCs have an ARM Realtime Core.
> > + * Firmware boot address has to be set in CR7BAR before
> > + * starting the realtime core.
> > + * Boot address must be aligned on a 256k boundary.
> > + */
> > +static int rcar_rst_set_gen3_rproc_boot_addr(u64 boot_addr)
> > +{
> > +       if (boot_addr & ~(u64)CR7BAR_MASK) {
> > +               pr_warn("Invalid boot address got %llx\n", boot_addr);
>
> pr_err
>
> > +               return -EINVAL;
> > +       }
> > +
> > +       iowrite32((u32)boot_addr, rcar_rst_base + CR7BAR);
> > +       iowrite32((u32)boot_addr | CR7BAREN, rcar_rst_base + CR7BAR);
>
> These casts to u32 are not needed.
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> i.e. will queue in renesas-devel for v5.17, with the above fixed
> (no need to resend).

Thanks, will send initial remoteproc support soon then !

Regards,
Julien