Hi Alex,
On Mon, Sep 13, 2021 at 7:05 PM Alex Helms
<alexander.helms.jy@xxxxxxxxxxx> wrote:
> Renesas 8T49N241 has 4 outputs, 1 integral and 3 fractional dividers.
> The 8T49N241 accepts up to two differential or single-ended input clocks
> and a fundamental-mode crystal input. The internal PLL can lock to either
> of the input reference clocks or to the crystal to behave as a frequency
> synthesizer.
>
> Signed-off-by: Alex Helms <alexander.helms.jy@xxxxxxxxxxx>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
Thanks for your patch!
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/renesas,8t49n241.yaml
> + reg:
> + description: I2C device address
> + enum: [ 0x7c, 0x6c, 0x7d, 0x6d, 0x7e, 0x6e, 0x7f, 0x6f ]
I think this is too strict: according to the datasheet, the full
device address can be customized when ordering.
> +examples:
> + i2c@0 {
> + reg = <0x0 0x100>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + renesas8t49n241_2: clock-generator@6c {
> + compatible = "renesas,8t49n241";
> + reg = <0x6c>;
> + #clock-cells = <1>;
> +
> + clocks = <&xtal>;
> + clock-names = "xtal";
> +
> + renesas,settings=[
Missing spaces around equal sign.
> + 09 50 00 60 67 C5 6C FF 03 00 30 00 00 01 00 00
[...]
> + ];
With the above fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
BTW, do you plan to add interrupt and/or GPIO support later?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
