Re: [PATCH v2] arm64: dts: renesas: r8a779a0: Add and connect all CSI-2, ISP and VIN nodes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 12, 2021 at 9:58 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> On Sun, Oct 10, 2021 at 7:52 PM Niklas Söderlund
> <niklas.soderlund+renesas@xxxxxxxxxxxx> wrote:
> > The V3U have 32 VIN, 4 CSI-2 and 4 ISP nodes that interact with each
> > other for video capture. Add all nodes and record how they are
> > interconnected.
> >
> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> > ---
> > * Changes since v1
> > - Fix endpoint for vin00 to vin07 that where missing @0 and
> >   {address,size}-cells and reg properties.
> > - Fix endpoint for all isp nodes that where missing @0 and
> >   {address,size}-cells and reg properties.
> > - Update compatible for ISP from renesas,isp-r8a779a0 to
> >   renesas,r8a779a0-isp.
>
> Thanks for the update!
>
> > The last binding document for the CSI-2 nodes are now merged in the
> > media-tree and this completes the coverage for the nodes in this patch.
> >
> > If you are happy with the corrections I made from v1 I think this is
> > ready to be picked up.
>
> The new version looks good to me, but I still get one complaint from
> "make dtbs_check", cfr. below.
>
> > --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
>
> > @@ -1268,6 +2164,426 @@ vspd1: vsp@fea28000 {
> >                         renesas,fcp = <&fcpvd1>;
> >                 };
> >
> > +               csi40: csi2@feaa0000 {
> > +                       compatible = "renesas,r8a779a0-csi2";
> > +                       reg = <0 0xfeaa0000 0 0x10000>;
> > +                       interrupts = <GIC_SPI 192 IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&cpg CPG_MOD 331>;
> > +                       power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > +                       resets = <&cpg 331>;
> > +                       status = "disabled";
> > +
> > +                       ports {
> > +                               #address-cells = <1>;
> > +                               #size-cells = <0>;
> > +
> > +                               port@1 {
> > +                                       reg = <1>;
> > +                                       csi40isp0: endpoint {
> > +                                               remote-endpoint = <&isp0csi40>;
> > +                                       };
> > +                               };
> > +                       };
> > +               };
> > +
> > +               csi41: csi2@feab0000 {
> > +                       compatible = "renesas,r8a779a0-csi2";
> > +                       reg = <0 0xfeab0000 0 0x10000>;
> > +                       interrupts = <GIC_SPI 193 IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&cpg CPG_MOD 400>;
> > +                       power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> > +                       resets = <&cpg 400>;
> > +                       status = "disabled";
> > +
> > +                       ports {
> > +                               #address-cells = <1>;
> > +                               #size-cells = <0>;
> > +
> > +                               port@1 {
> > +                                       reg = <1>;
> > +                                       csi41isp1: endpoint {
> > +                                               remote-endpoint = <&isp1csi41>;
> > +                                       };
> > +                               };
>
> arch/arm64/boot/dts/renesas/r8a779a0-falcon.dt.yaml: csi2@feab0000:
> ports: 'port@0' is a required property
> From schema: Documentation/devicetree/bindings/media/renesas,csi2.yaml
>
> (only for this CSI instance).

My local tree also has your "arm64: dts: renesas: falcon-csi-dsi:
Add and connect MAX96712", which adds the missing port@0 subnodes
to all CSI instances but csi41.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux