Hello Morimoro-san, Thanks for your test. On 2021-10-12 12:11:01 +0900, Kuninori Morimoto wrote: > > Hi Niklas > > Thank you for the patches. > > > 1. Check that the driver uses the fused values, this is showed by the > > log message, dev_info(dev, "Using fused calibration values\n"); is > > trigged when the driver probe. > > > > 2. Check the temperature readings in sysfs are reasonable, the values are > > in millidegree Celsius. On my system that uses the coefficients from > > the driver I have 41-42 degrees Celsius at the moment. > > > > # grep . /sys/class/thermal/thermal_zone*/temp > > /sys/class/thermal/thermal_zone0/temp:41000 > > /sys/class/thermal/thermal_zone1/temp:42000 > > /sys/class/thermal/thermal_zone2/temp:41000 > > I checkout:ed v5.15-rc4, and apply your patches. > This is the result > > --- log ---- > ... > [ 1.516781] i2c-rcar e6510000.i2c: probed > [ 1.532108] i2c-rcar e66d8000.i2c: probed > => [ 1.539314] rcar_gen3_thermal e6198000.thermal: Using fused calibration values > [ 1.551116] rcar_gen3_thermal e6198000.thermal: TSC0: Loaded 1 trip points > [ 1.562274] rcar_gen3_thermal e6198000.thermal: TSC1: Loaded 1 trip points > [ 1.573413] rcar_gen3_thermal e6198000.thermal: TSC2: Loaded 2 trip points > [ 1.595676] random: fast init done > [ 1.612993] NET: Registered PF_PACKET protocol family > ... > # login > => # grep . /sys/class/thermal/thermal_zone*/temp > /sys/class/thermal/thermal_zone0/temp:37000 > /sys/class/thermal/thermal_zone1/temp:38500 > /sys/class/thermal/thermal_zone2/temp:38500 > > I'm happy if these are the expected. > > Tested-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> These are reasonable temperature readings, unless you moved to an igloo to live with the penguins :-) Thanks again for locating a board and taking the time to test this series much appreciated! > > Thank you for your help !! > > Best regards > --- > Kuninori Morimoto -- Regards, Niklas Söderlund
