Hi Sergey,
> Subject: Re: [RFC 08/12] ravb: Add carrier_counters to struct ravb_hw_info
>
> On 10/6/21 7:41 PM, Sergey Shtylyov wrote:
>
> >> RZ/G2L E-MAC supports carrier counters.
> >> Add a carrier_counter hw feature bit to struct ravb_hw_info to add
> >> this feature only for RZ/G2L.
> >>
> >> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> >> Reviewed-by: Sergey Shtylyov <s.shtylyov@xxxxxx>
> >
> > [...]
> >
> >> diff --git a/drivers/net/ethernet/renesas/ravb.h
> >> b/drivers/net/ethernet/renesas/ravb.h
> >> index 8c7b2569c7dd..899e16c5eb1a 100644
> >> --- a/drivers/net/ethernet/renesas/ravb.h
> >> +++ b/drivers/net/ethernet/renesas/ravb.h
> >> [...]
> >> @@ -1061,6 +1065,7 @@ struct ravb_hw_info {
> >> unsigned nc_queue:1; /* AVB-DMAC has NC queue */
> >> unsigned magic_pkt:1; /* E-MAC supports magic packet
> detection */
> >> unsigned half_duplex:1; /* E-MAC supports half duplex mode */
> >> + unsigned carrier_counters:1; /* E-MAC has carrier counters */
>
> I thought I'd typed here that this field should be declared next to the
> 'tx_counters' field. :-)
Agreed. Will move to 'tx_counters' field.
Regards,
Biju
