Re: [PATCH] arm64: dts: renesas: beacon: Fix memory corruption from TF-A

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Adam,

On Fri, Sep 24, 2021 at 7:19 PM Adam Ford <aford173@xxxxxxxxx> wrote:
> Trusted Firmware allocates a chunk of memory for a lossy compressor
> which makes the memory unavailable to Linux and any attempts to read/write
> from Linux result in memory corruption or a crash.  Fix this by reserving
> the section of memory marked as unavailable by TF-A.
>
> Fixes: a1d8a344f1ca ("arm64: dts: renesas: Introduce r8a774a1-beacon-rzg2m-kit")
> Signed-off-by: Adam Ford <aford173@xxxxxxxxx>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi
> +++ b/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi
> @@ -13,6 +13,17 @@ memory@48000000 {
>                 reg = <0x0 0x48000000 0x0 0x78000000>;
>         };
>
> +       reserved-memory {
> +               #address-cells = <2>;
> +               #size-cells = <2>;
> +               ranges;
> +
> +               lossy_decompress: lossy-decompress@54000000 {
> +                       reg = <0 0x54000000 0 0x03000000>; /* Reserved by TF-A */
> +                       no-map;
> +               };
> +       };
> +
>         osc_32k: osc_32k {
>                 compatible = "fixed-clock";
>                 #clock-cells = <0>;

I believe these days it's the responsibility of TF-A to create these nodes
in the DTB, and pass that to U-Boot.

What bootloader are you running?
Does "fdt addr $fdtcontroladdr ; fdt print" show the area as reserved?
Does TF-A print something about reserving the memory?

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux