Re: [PATCH v2] soc: renesas: rcar-rst: Add support to set rproc boot address

[Julien Massot <julien.massot@xxxxxxx>]

Hi,

> +/*
> + * Most of R-Car Gen3 SoCs have an ARM Realtime Core.
> + * Firmware boot address can be set before starting,
> + * the realtime core thanks to CR7BAR register.
> + * Boot address is on 32bit, and should be aligned on
> + * 4k boundary.
> + */
> +int rcar_rst_set_gen3_rproc_boot_addr(u32 boot_addr)
> +{
> +	if (boot_addr % SZ_4K) {
> +		pr_warn("Invalid boot address for CR7 processor,"
> +		       "should be aligned on 4k got %x\n", boot_addr);
> +		return -EINVAL;
> +	}
Just notice that this 4K value is wrong, CR7BAR should be aligned on 256K.
Any comments about this v2 before I send an update ?

Regards,
--
Julien Massot [IoT.bzh]