On 9/23/21 5:08 PM, Biju Das wrote:
> This patch adds rx_ring_free function support for GbEthernet
> found on RZ/G2L SoC.
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> ---
> drivers/net/ethernet/renesas/ravb_main.c | 22 +++++++++++++++++++++-
> 1 file changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
> index 2c375002ebcb..038af36141bb 100644
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -236,7 +236,27 @@ static int ravb_tx_free(struct net_device *ndev, int q, bool free_txed_only)
>
> static void ravb_rx_ring_free_rgeth(struct net_device *ndev, int q)
> {
> - /* Place holder */
> + struct ravb_private *priv = netdev_priv(ndev);
> + unsigned int ring_size;
> + unsigned int i;
> +
> + if (!priv->rgeth_rx_ring[q])
Is the network control queue present on your hardware at all? Perhaps we can ignore q for now?
> + return;
> +
> + for (i = 0; i < priv->num_rx_ring[q]; i++) {
> + struct ravb_rx_desc *desc = &priv->rgeth_rx_ring[q][i];
Looks like patch #12 should come after this one, not before...
> +
> + if (!dma_mapping_error(ndev->dev.parent,
> + le32_to_cpu(desc->dptr)))
> + dma_unmap_single(ndev->dev.parent,
> + le32_to_cpu(desc->dptr),
> + RGETH_RX_BUFF_MAX,
> + DMA_FROM_DEVICE);
> + }
> + ring_size = sizeof(struct ravb_rx_desc) * (priv->num_rx_ring[q] + 1);
> + dma_free_coherent(ndev->dev.parent, ring_size, priv->rgeth_rx_ring[q],
> + priv->rx_desc_dma[q]);
> + priv->rgeth_rx_ring[q] = NULL;
> }
>
> static void ravb_rx_ring_free(struct net_device *ndev, int q)
MBR, Sergey
