Hi removed most cc, due to server limitation W dniu 24.09.2021 o 10:03, Jani Nikula pisze: > On Mon, 20 Sep 2021, Doug Anderson <dianders@xxxxxxxxxxxx> wrote: >> Pushed all 15 to drm-misc-next. > ... >> e8de4d55c259 drm/edid: Use new encoded panel id style for quirks matching >> d9f91a10c3e8 drm/edid: Allow querying/working with the panel ID from >> the EDID > Hi Doug, Stan's reporting "initializer element is not constant" issues > here that were discussed before [1]. I wonder what gives, you said you'd > hit them on a draft version, but not with what was merged, and I can't > reproduce this either. Curious. Apparently this is grey area of unclear specification. gcc version below 8 reports error, above 8.1+ should work [1]. I am not sure if there is nice workaround for older gcc. [1]: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69960#c18 Regards Andrzej > BR, > Jani. > > > In file included from drivers/gpu/drm/drm_edid.c:42:0: > ./include/drm/drm_edid.h:525:2: error: initializer element is not constant > ((((u32)((vend)[0]) - '@') & 0x1f) << 26 | \ > ^ > drivers/gpu/drm/drm_edid.c:111:14: note: in expansion of macro > ‘drm_edid_encode_panel_id’ > .panel_id = drm_edid_encode_panel_id(vend, product_id), \ > ^~~~~~~~~~~~~~~~~~~~~~~~ > drivers/gpu/drm/drm_edid.c:120:2: note: in expansion of macro ‘EDID_QUIRK’ > EDID_QUIRK("ACR", 44358, EDID_QUIRK_PREFER_LARGE_60), > ^~~~~~~~~~ > ./include/drm/drm_edid.h:525:2: note: (near initialization for > ‘edid_quirk_list[0].panel_id’) > ((((u32)((vend)[0]) - '@') & 0x1f) << 26 | \ > ^ > drivers/gpu/drm/drm_edid.c:111:14: note: in expansion of macro > ‘drm_edid_encode_panel_id’ > .panel_id = drm_edid_encode_panel_id(vend, product_id), \ > ^~~~~~~~~~~~~~~~~~~~~~~~ > drivers/gpu/drm/drm_edid.c:120:2: note: in expansion of macro ‘EDID_QUIRK’ > EDID_QUIRK("ACR", 44358, EDID_QUIRK_PREFER_LARGE_60), > ^~~~~~~~~~ > > > [1] > https://lore.kernel.org/all/CAD=FV=XHvFq5+Rtax7WNq2-BieQr-BM4UnmOcma_eTzkX2ZtNA@xxxxxxxxxxxxxx/ > >
