Re: [RFC PATCH 1/4] clk: renesas: cpg-lib: move RPC clock registration to the library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 13, 2021 at 8:53 AM Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> We want to reuse this code for V3U soon. Because its RPCCKCR register is
> at a different offset, the moved functions do not use the base register
> as an argument anymore but the RPCCKCR register itself. Otherwise it is
> a plain code move. Verified that an Eagle board with R-Car V3M still
> works.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

> These new library functions use CLK_SET_RATE_PARENT in
> clk_register_composite() as flags. This is what the current upstream
> code does. The V3U BSP, however, doesn't use this flag and passes 0 as
> an argument. It doesn't matter much currently, because the RPC drivers
> do not use any clk function calls. Yet, I think the flags provided
> should be consistent, so I kept what was already upstream. D'accord?

Akkoord ;-)

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux