Hi Marek,
Thanks for your patch!
On Tue, Sep 7, 2021 at 4:45 PM <marek.vasut@xxxxxxxxx> wrote:
> From: Marek Vasut <marek.vasut+renesas@xxxxxxxxx>
>
> Add COMMON_CLK dependency, otherwise the following build error occurs:
> arm-linux-gnueabi-ld: drivers/pci/controller/pcie-rcar-host.o: in function `rcar_pcie_aarch32_abort_handler':
> pcie-rcar-host.c:(.text+0xdd0): undefined reference to `__clk_is_enabled'
This is a link failure for the host driver...
> This should be OK, since all platforms shipping this controller also
> need COMMON_CLK enabled for their clock driver.
>
> Fixes: a115b1bd3af0 ("PCI: rcar: Add L1 link state fix into data abort hook")
> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx>
> Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>
> Cc: Stephen Boyd <sboyd@xxxxxxxxxx>
> Cc: Wolfram Sang <wsa@xxxxxxxxxxxxx>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> Cc: linux-renesas-soc@xxxxxxxxxxxxxxx
> ---
> +CC Stephen, please double-check whether this is the right approach or
> whether there is some better option
> ---
> drivers/pci/controller/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> index 326f7d13024f..ee6f5e525d3a 100644
> --- a/drivers/pci/controller/Kconfig
> +++ b/drivers/pci/controller/Kconfig
> @@ -66,6 +66,7 @@ config PCI_RCAR_GEN2
> config PCIE_RCAR_HOST
> bool "Renesas R-Car PCIe host controller"
> depends on ARCH_RENESAS || COMPILE_TEST
> + depends on COMMON_CLK
This part is OK.
> depends on PCI_MSI_IRQ_DOMAIN
> help
> Say Y here if you want PCIe controller support on R-Car SoCs in host
> @@ -74,6 +75,7 @@ config PCIE_RCAR_HOST
> config PCIE_RCAR_EP
> bool "Renesas R-Car PCIe endpoint controller"
> depends on ARCH_RENESAS || COMPILE_TEST
> + depends on COMMON_CLK
... so why did you add a dependency to the endpoint driver, too?
> depends on PCI_ENDPOINT
> help
> Say Y here if you want PCIe controller support on R-Car SoCs in
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
