Validate the routing table by making sure all the routes start from a
sink pad and end in a source pad and that the stream numbers are
correct.
Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>
---
drivers/media/i2c/max9286.c | 50 ++++++++++++++++++++++++++++++++++++-
1 file changed, 49 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
index 79af880147d0..931c4f542c77 100644
--- a/drivers/media/i2c/max9286.c
+++ b/drivers/media/i2c/max9286.c
@@ -942,6 +942,54 @@ static int max9286_get_frame_desc(struct v4l2_subdev *sd, unsigned int pad,
return ret;
}
+static int max9286_routing_verify(struct max9286_priv *priv,
+ struct v4l2_subdev_krouting *routing)
+{
+ unsigned int i;
+ int ret;
+
+ ret = v4l2_routing_simple_verify(routing);
+ if (ret)
+ return ret;
+
+ /*
+ * Make sure all routes points to the single source pad which can have
+ * up to 4 streams. All routes shall start from a sink pad and shall not
+ * have more than one sink stream. The GMSL link for the sink has to be
+ * enabled.
+ */
+ for (i = 0; i < routing->num_routes; ++i) {
+ const struct v4l2_subdev_route *route = &routing->routes[i];
+ struct max9286_source *source = &priv->sources[i];
+
+ if (route->source_pad != MAX9286_SRC_PAD ||
+ route->source_stream > 4) {
+ dev_err(&priv->client->dev,
+ "Invalid (%u,%u) source in route %u\n",
+ route->source_pad, route->source_stream, i);
+ return -EINVAL;
+ }
+
+ if (route->sink_pad >= MAX9286_N_SINKS ||
+ route->sink_stream != 0) {
+ dev_err(&priv->client->dev,
+ "Invalid (%u,%u) sink in route %u\n",
+ route->sink_pad, route->sink_stream, i);
+ return -EINVAL;
+ }
+
+ source = &priv->sources[route->sink_pad];
+ if (!source->fwnode) {
+ dev_err(&priv->client->dev,
+ "Cannot set route for non-active source %u\n",
+ route->sink_pad);
+ return -EINVAL;
+ }
+ }
+
+ return 0;
+}
+
static int __max9286_set_routing(struct v4l2_subdev *sd,
struct v4l2_subdev_state *state,
struct v4l2_subdev_krouting *routing)
@@ -958,7 +1006,7 @@ static int __max9286_set_routing(struct v4l2_subdev *sd,
if (routing->num_routes >= V4L2_FRAME_DESC_ENTRY_MAX)
return -EINVAL;
- ret = v4l2_routing_simple_verify(routing);
+ ret = max9286_routing_verify(priv, routing);
if (ret)
return ret;
--
2.32.0
