Re: [PATCH] arm64: dts: renesas: r8a77961: Add TPU device node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wolfram,

On Fri, Aug 27, 2021 at 9:38 AM Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> Add the missing TPU node for the R-Car M3-W+ SoC.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> @@ -1367,6 +1367,17 @@ scif5: serial@e6f30000 {
>                         status = "disabled";
>                 };
>
> +               tpu: pwm@e6e80000 {
> +                       compatible = "renesas,tpu-r8a77961", "renesas,tpu";

scripts/checkpatch.pl:

    WARNING: DT compatible string "renesas,tpu-r8a77961" appears
un-documented -- check ./Documentation/devicetree/bindings/
    #34: FILE: arch/arm64/boot/dts/renesas/r8a77961.dtsi:1371:

make dtbs_check:

    arch/arm64/boot/dts/renesas/r8a77961-ulcb.dt.yaml: pwm@e6e80000:
compatible:0: 'renesas,tpu-r8a77961' is not one of
['renesas,tpu-r8a73a4', 'renesas,tpu-r8a7740', 'renesas,tpu-r8a7742',
'renesas,tpu-r8a7743', 'renesas,tpu-r8a7744', 'renesas,tpu-r8a7745',
'renesas,tpu-r8a7790', 'renesas,tpu-r8a7791', 'renesas,tpu-r8a7792',
'renesas,tpu-r8a7793', 'renesas,tpu-r8a7794', 'renesas,tpu-r8a7795',
'renesas,tpu-r8a7796', 'renesas,tpu-r8a77965', 'renesas,tpu-r8a77970',
'renesas,tpu-r8a77980']

Any chance you can send a DT binding update? TIA!

> +                       reg = <0 0xe6e80000 0 0x148>;
> +                       interrupts = <GIC_SPI 135 IRQ_TYPE_LEVEL_HIGH>;
> +                       clocks = <&cpg CPG_MOD 304>;
> +                       power-domains = <&sysc R8A77961_PD_ALWAYS_ON>;
> +                       resets = <&cpg 304>;
> +                       #pwm-cells = <3>;
> +                       status = "disabled";
> +               };
> +
>                 msiof0: spi@e6e90000 {
>                         compatible = "renesas,msiof-r8a77961",
>                                      "renesas,rcar-gen3-msiof";

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
i.e. will queue in renesas-devel for v5.16.

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux