Hi Jacopo,
Thank you for the patch.
On Tue, Aug 17, 2021 at 09:26:59AM +0200, Jacopo Mondi wrote:
> Support for the MAX9271 GMSL serializer was provided in the form of a
> library driver, with the RDACM20 and RDACM21 camera module drivers using
> the functions exported by the library.
>
> In preparation to introduce an i2c subdevice driver to support the
> MAX9271 serializer, rename the library driver from max9271 to
> max9271-lib.
>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
Even if the series ended up being rejected (due, for instance, to
realizing this would be a bad approach), this may make sense on its own.
> ---
> MAINTAINERS | 8 ++++----
> drivers/media/i2c/Makefile | 2 +-
> drivers/media/i2c/{max9271.c => max9271-lib.c} | 2 +-
> drivers/media/i2c/{max9271.h => max9271-lib.h} | 0
> drivers/media/i2c/rdacm20.c | 2 +-
> drivers/media/i2c/rdacm21.c | 2 +-
> 6 files changed, 8 insertions(+), 8 deletions(-)
> rename drivers/media/i2c/{max9271.c => max9271-lib.c} (99%)
> rename drivers/media/i2c/{max9271.h => max9271-lib.h} (100%)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 524eabe50d79..7ad89cac19b7 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15625,8 +15625,8 @@ M: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> L: linux-media@xxxxxxxxxxxxxxx
> S: Maintained
> F: Documentation/devicetree/bindings/media/i2c/imi,rdacm2x-gmsl.yaml
> -F: drivers/media/i2c/max9271.c
> -F: drivers/media/i2c/max9271.h
> +F: drivers/media/i2c/max9271-lib.c
> +F: drivers/media/i2c/max9271-lib.h
> F: drivers/media/i2c/rdacm20.c
>
> RDACM21 Camera Sensor
> @@ -15637,8 +15637,8 @@ M: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> L: linux-media@xxxxxxxxxxxxxxx
> S: Maintained
> F: Documentation/devicetree/bindings/media/i2c/imi,rdacm2x-gmsl.yaml
> -F: drivers/media/i2c/max9271.c
> -F: drivers/media/i2c/max9271.h
> +F: drivers/media/i2c/max9271-lib.c
> +F: drivers/media/i2c/max9271-lib.h
> F: drivers/media/i2c/rdacm21.c
>
> RDC R-321X SoC
> diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile
> index 83268f20aa3a..4d879373bd48 100644
> --- a/drivers/media/i2c/Makefile
> +++ b/drivers/media/i2c/Makefile
> @@ -129,7 +129,7 @@ obj-$(CONFIG_VIDEO_IMX335) += imx335.o
> obj-$(CONFIG_VIDEO_IMX355) += imx355.o
> obj-$(CONFIG_VIDEO_IMX412) += imx412.o
> obj-$(CONFIG_VIDEO_MAX9286) += max9286.o
> -obj-$(CONFIG_VIDEO_MAX9271_LIB) += max9271.o
> +obj-$(CONFIG_VIDEO_MAX9271_LIB) += max9271-lib.o
> obj-$(CONFIG_VIDEO_RDACM20) += rdacm20.o
> obj-$(CONFIG_VIDEO_RDACM21) += rdacm21.o
> obj-$(CONFIG_VIDEO_ST_MIPID02) += st-mipid02.o
> diff --git a/drivers/media/i2c/max9271.c b/drivers/media/i2c/max9271-lib.c
> similarity index 99%
> rename from drivers/media/i2c/max9271.c
> rename to drivers/media/i2c/max9271-lib.c
> index ff86c8c4ea61..c554bb0f42f4 100644
> --- a/drivers/media/i2c/max9271.c
> +++ b/drivers/media/i2c/max9271-lib.c
> @@ -20,7 +20,7 @@
> #include <linux/i2c.h>
> #include <linux/module.h>
>
> -#include "max9271.h"
> +#include "max9271-lib.h"
>
> static int max9271_read(struct max9271_device *dev, u8 reg)
> {
> diff --git a/drivers/media/i2c/max9271.h b/drivers/media/i2c/max9271-lib.h
> similarity index 100%
> rename from drivers/media/i2c/max9271.h
> rename to drivers/media/i2c/max9271-lib.h
> diff --git a/drivers/media/i2c/rdacm20.c b/drivers/media/i2c/rdacm20.c
> index eb0e3dc22cc3..bf06a1c50306 100644
> --- a/drivers/media/i2c/rdacm20.c
> +++ b/drivers/media/i2c/rdacm20.c
> @@ -27,7 +27,7 @@
> #include <media/v4l2-ctrls.h>
> #include <media/v4l2-subdev.h>
>
> -#include "max9271.h"
> +#include "max9271-lib.h"
>
> #define OV10635_I2C_ADDRESS 0x30
>
> diff --git a/drivers/media/i2c/rdacm21.c b/drivers/media/i2c/rdacm21.c
> index 35217782f693..3a05abe4e96c 100644
> --- a/drivers/media/i2c/rdacm21.c
> +++ b/drivers/media/i2c/rdacm21.c
> @@ -21,7 +21,7 @@
> #include <media/v4l2-async.h>
> #include <media/v4l2-ctrls.h>
> #include <media/v4l2-subdev.h>
> -#include "max9271.h"
> +#include "max9271-lib.h"
>
> #define MAX9271_RESET_CYCLES 10
>
--
Regards,
Laurent Pinchart
