Hi Colin, Thank you for the patch. > -----Original Message----- > From: Colin King <colin.king@xxxxxxxxxxxxx> > Sent: 17 August 2021 18:21 > To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>; Jonathan Cameron > <jic23@xxxxxxxxxx>; Lars-Peter Clausen <lars@xxxxxxxxxx>; Biju Das <biju.das.jz@xxxxxxxxxxxxxx>; > linux-iio@xxxxxxxxxxxxxxx; linux-renesas-soc@xxxxxxxxxxxxxxx > Cc: kernel-janitors@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: [PATCH][next] iio: adc: Fix -EBUSY timeout error return > > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > Currently when a timeout occurs in rzg2l_adc_hw_init the error -EBUSY is assigned to ret but the error > code is used as the function is hard-coded to return 0. The variable ret is 0 before entering the > while-loop hence the fix is just to return ret at the end of the function to return the success 0 or - > EBUSY return code. > > Addresses-Coverity: ("Unused value") > Fixes: d484c21bacfa ("iio: adc: Add driver for Renesas RZ/G2L A/D converter") > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> > --- > drivers/iio/adc/rzg2l_adc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > iio: adc: rzg2l_adc: Fix -EBUSY timeout error return with the subject changed to above: Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> Cheers, Prabhakar > diff --git a/drivers/iio/adc/rzg2l_adc.c b/drivers/iio/adc/rzg2l_adc.c index > 9996d5eef289..868b183e75ea 100644 > --- a/drivers/iio/adc/rzg2l_adc.c > +++ b/drivers/iio/adc/rzg2l_adc.c > @@ -401,7 +401,7 @@ static int rzg2l_adc_hw_init(struct rzg2l_adc *adc) > exit_hw_init: > clk_disable_unprepare(adc->pclk); > > - return 0; > + return ret; > } > > static void rzg2l_adc_pm_runtime_disable(void *data) > -- > 2.32.0